support grafana domain#3
Merged
dghelm merged 3 commits intoscroll-tech:mainfrom Oct 25, 2024
shu-unifra:scroll-monitor
Merged
Conversation
This was referenced Oct 22, 2024
dghelm
approved these changes
Oct 25, 2024
Contributor
dghelm
left a comment
dghelm
left a comment
There was a problem hiding this comment.
Looks good to me -- will test alongside other changes being worked on.
Thanks!
tony-unifra
referenced
this pull request
in DogeOS69/scroll-sdk-cli
Apr 16, 2025
fix e2e and other bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable monitoring with Grafana, Prometheus, and Alertmanager.
Key Changes:
Allow this tool to configure Grafana's domain name
Related PRs
scroll-tech/scroll-documentation#376
scroll-tech/scroll-sdk#196
Merge Notes
This PR better be merged in sync with the other repository's PR to prevent breaking changes or inconsistencies. Please ensure these PRs are merged simultaneously.